[DO NOT REVIEW] Merge Contact Information Feature Branch #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add contact information data class * Add ContactInformation request model * Add UTs * Update CHANGELOG
* Add contact information data class * Add ContactInformation request model * Add UTs * Update CHANGELOG * Add contact information toggle
# Conflicts: # CHANGELOG.md
sarahkoop
reviewed
Jan 8, 2025
| @@ -64,6 +64,7 @@ class PayPalCheckoutRequest @JvmOverloads constructor( | |||
| var currencyCode: String? = null, | |||
| var shouldRequestBillingAgreement: Boolean = false, | |||
| var shouldOfferPayLater: Boolean = false, | |||
| var contactInformation: PayPalContactInformation? = null, | |||
There was a problem hiding this comment.
I know this is the final PR not requiring review but realized we are missing the doc string for this property - iOS has Optional: Contact information of the recipient for the order
There was a problem hiding this comment.
Good catch, looks like we don't use the Optional part on Android based on the docstrings here, added the missing one here: 028271a
sarahkoop
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Authors
@richherrera @jaxdesmarais