[V7] Add Encodable protocol for PayPal Vault
#1492
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and Vault encodable objects
jaxdesmarais
reviewed
Jan 8, 2025
| @@ -401,6 +403,21 @@ import BraintreeDataCollector | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private func encodedPostBody(fromRequest payPalRequest: BTPayPalRequest, configuration: BTConfiguration) -> Encodable? { | |||
There was a problem hiding this comment.
Suggested change
| private func encodedPostBody(fromRequest payPalRequest: BTPayPalRequest, configuration: BTConfiguration) -> Encodable? { | |
| private func encodedPostBody(from payPalRequest: BTPayPalRequest, configuration: BTConfiguration) -> Encodable? { |
| @@ -401,6 +403,21 @@ import BraintreeDataCollector | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private func encodedPostBody(fromRequest payPalRequest: BTPayPalRequest, configuration: BTConfiguration) -> Encodable? { | |||
| if let checkoutRequest = payPalRequest as? BTPayPalCheckoutRequest { | |||
There was a problem hiding this comment.
Could we instead do a switch here on payPalRequest.paymentType?
| @@ -114,6 +119,8 @@ public enum BTPayPalError: Error, CustomNSError, LocalizedError, Equatable { | |||
| return "Missing BA Token for PayPal App Switch." | |||
| case .missingPayPalRequest: | |||
| return "The PayPal Request was missing or invalid." | |||
| case .failedToCreateEncodable: | |||
| return "Unable to create Encodable object" | |||
There was a problem hiding this comment.
This may make it a bit more clear, but take it or leave it:
Suggested change
| return "Unable to create Encodable object" | |
| return "The request was not a Checkout or Vault request." |
| @@ -350,19 +350,21 @@ import BraintreeDataCollector | |||
|
|
|||
| self.isConfigFromCache = configuration.isFromCache | |||
|
|
|||
| guard json["paypalEnabled"].isTrue else { | |||
| guard configuration.isPayPalEnabled else { | |||
There was a problem hiding this comment.
I think we can also remove let json = configuration.json above on line 346
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
postbodies used in the PayPal Vault flow.Checklist
[ ] Added a changelog entryAuthors