upgrade to react 17 #1169
Closed
upgrade to react 17 #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mason Fish <[email protected]>
|
It looks like the failure is from our enzyme react adapter. Maybe this works? https://www.npmjs.com/package/@wojtekmaj/enzyme-adapter-react-17 |
|
update: while my personal testing and integrations pass, the unit testing is blocked on the enzyme lib's react adapter update (enzymejs/enzyme#2429 (comment)) I'll close for now, and reopen when that changes. |
|
@jameskerr I thought it would be better to wait for the official adapter since we aren't desperate to upgrade, wdyt? |
|
Sounds good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in their release notes, there are no new features and very minimal breaking changes in this major release bump. The only thing I saw that we can change is removing the event persistence, which is no longer necessary. All manual and automated testing has passed locally.
signed-off-by: Mason Fish [email protected]