Skip to content

Commit

Permalink
Improve warning log
Browse files Browse the repository at this point in the history
  • Loading branch information
sam-schu committed Dec 13, 2024
1 parent 7233923 commit 02437d2
Showing 1 changed file with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,12 @@ trait GetRequestHandler { this: RequestHandler =>
gpusList <- Option(virtualMachine.getAccelerators)
gpus <- {
if (gpusList.size > 1) {
// TODO: Improve this warning
// - Log appears repeatedly while task is running
// - Improve formatting of accelerator info
// - Include workflow/task ID?
logger.warn(

Check warning on line 129 in supportedBackends/google/pipelines/v2beta/src/main/scala/cromwell/backend/google/pipelines/v2beta/api/request/GetRequestHandler.scala

View check run for this annotation

Codecov / codecov/patch

supportedBackends/google/pipelines/v2beta/src/main/scala/cromwell/backend/google/pipelines/v2beta/api/request/GetRequestHandler.scala#L129

Added line #L129 was not covered by tests
"Multiple GPU types present for a single task. Only the first will be used for cost calculations"
s"Multiple GPU types present ($gpusList) for a single task. Only the first will be used for cost calculations."
)
}
gpusList.asScala.headOption
Expand Down

0 comments on commit 02437d2

Please sign in to comment.