Skip to content

Commit

Permalink
WX-1595 Fix batch workflow options override (#7466)
Browse files Browse the repository at this point in the history
Co-authored-by: SophiaPerzan-DG <[email protected]>
  • Loading branch information
aednichols and SophiaPerzan-DG authored Jul 3, 2024
1 parent 49d675d commit 80fe846
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ be found [here](https://cromwell.readthedocs.io/en/stable/backends/HPC/#optional
- The `genomics` configuration entry was renamed to `batch`, see [ReadTheDocs](https://cromwell.readthedocs.io/en/stable/backends/GCPBatch/) for more information.
- Fixes the preemption error handling, now, the correct error message is printed, this also handles the other potential exit codes.
- Fixes pulling Docker image metadata from private GCR repositories.
- Fixed `google_project` and `google_compute_service_account` workflow options not taking effect when using GCP Batch backend

### Improved handling of Life Sciences API quota errors

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ class GcpBatchRequestFactoryImpl()(implicit gcsTransferConfiguration: GcsTransfe

override def submitRequest(data: GcpBatchRequest): CreateJobRequest = {

val batchAttributes = data.gcpBatchParameters.batchAttributes
val runtimeAttributes = data.gcpBatchParameters.runtimeAttributes
val createParameters = data.createParameters
val retryCount = data.gcpBatchParameters.runtimeAttributes.preemptible
Expand All @@ -165,8 +164,8 @@ class GcpBatchRequestFactoryImpl()(implicit gcsTransferConfiguration: GcsTransfe
val gcpBootDiskSizeMb = convertGbToMib(runtimeAttributes)

// set parent for metadata storage of job information
lazy val parent = s"projects/${data.gcpBatchParameters.projectId}/locations/${data.gcpBatchParameters.region}"
val gcpSa = ServiceAccount.newBuilder.setEmail(batchAttributes.computeServiceAccount).build
lazy val parent = s"projects/${createParameters.projectId}/locations/${data.gcpBatchParameters.region}"
val gcpSa = ServiceAccount.newBuilder.setEmail(createParameters.computeServiceAccount).build

// make zones path
val zones = toZonesPath(runtimeAttributes.zones)
Expand Down

0 comments on commit 80fe846

Please sign in to comment.