Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RW-12676 add resource request/limit #288

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RW-12676 add resource request/limit #288

wants to merge 1 commit into from

Conversation

Qi77Qi
Copy link

@Qi77Qi Qi77Qi commented Jun 10, 2024

  1. Add an autopilot.enabled flag
  2. Add resources section if autopilot.enabled is true.

cjllanwarne
cjllanwarne approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@cjllanwarne cjllanwarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really something I maintain any more but looks good at first glance. I assume this is not going to hurt anything if deployed to the other cloud?

@Qi77Qi
Copy link
Author

Qi77Qi commented Jun 11, 2024

@cjllanwarne as long as no one intentionally sets autopilot.enabled to true, this won't affect anything...but if somehow leo sets it to true for Azure, then the impact would be that these containers have certain resource constraints (which also applies in standard mode)

I haven't made any change in leo to set autopilot.enabled yet...But I'll request review from u both when I do just in case any surprises

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjllanwarne cjllanwarne cjllanwarne approved these changes

@jgainerdewar jgainerdewar jgainerdewar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qi77Qi @jgainerdewar @cjllanwarne