Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#4] - Update for swagger documentation #4

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

DatHoang102003
Copy link
Contributor

@DatHoang102003 DatHoang102003 commented Oct 18, 2024

Pull Request Template

Description

Please include a summary of the changes and the related issue.

Fixes #2

Type of Change

  • Bug fix
  • [Add swagger documentation] New feature
  • Breaking change

Checklist

  • [ ✓] I have read the contribution guidelines.
  • [ ✓] I have followed the code style guidelines.
  • [ ✓] I have added tests that prove my fix is effective or that my feature works.
  • [ ✓] All new and existing tests passed.

Screenshots (if applicable)

Attach screenshots to better demonstrate the changes, if applicable.

@DatHoang102003
Copy link
Contributor Author

Oh and here is the screenshot:
image

Copy link
Contributor

@akbatra567 akbatra567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DatHoang102003,
Could you remove comments ? The code is self explanatory hence comments are not needed.

@akbatra567
Copy link
Contributor

@DatHoang102003
Also could you change the PR name as per template ?

Example: 'feat: [#123] - my title'

@DatHoang102003 DatHoang102003 changed the title Code update for swagger documentation feat: [#123] -Update for swagger documentation Oct 18, 2024
@DatHoang102003
Copy link
Contributor Author

I've updated the code and the PR title as per your request. Could you please review it for merging?

@DatHoang102003 DatHoang102003 changed the title feat: [#123] -Update for swagger documentation feat: [#4] -Update for swagger documentation Oct 18, 2024
@akbatra567 akbatra567 changed the title feat: [#4] -Update for swagger documentation feat: [#4] - Update for swagger documentation Oct 18, 2024
@akbatra567 akbatra567 merged commit 235a7ea into building-for-fun:main Oct 18, 2024
1 of 4 checks passed
@akbatra567 akbatra567 added the hacktoberfest-accepted PR label for Hacktoberfest label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PR label for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[backend]: Setup swagger documentation for backend directory
2 participants