feat(helm): add ability to activate -web.enable-reload flag (#606)

* Update README.md * Update deployment.yaml * Update values.yaml * bump helm chart and rename reload-prop
burningalchemist · Oct 14, 2024 · 0833fd9 · 0833fd9
1 parent 131c783
commit 0833fd9
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/helm/Chart.yaml b/helm/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: sql-exporter
 description: Database-agnostic SQL exporter for Prometheus
 type: application
-version: 0.7.0
+version: 0.8.0
 appVersion: 0.15.0
 keywords:
   - exporter

diff --git a/helm/README.md b/helm/README.md
@@ -1,6 +1,6 @@
 # sql-exporter
 
-![Version: 0.7.0](https://img.shields.io/badge/Version-0.7.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.15.0](https://img.shields.io/badge/AppVersion-0.15.0-informational?style=flat-square)
+![Version: 0.8.0](https://img.shields.io/badge/Version-0.8.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.15.0](https://img.shields.io/badge/AppVersion-0.15.0-informational?style=flat-square)
 
 Database-agnostic SQL exporter for Prometheus
 
@@ -51,6 +51,7 @@ helm install sql_exporter/sql-exporter
 | podAnnotations | object | `{}` | Pod annotations |
 | podSecurityContext | object | `{}` | Pod security context |
 | createConfig | bool | `true` |  |
+| reloadEnabled | bool | `false` | Enable reload collector data handler (endpoint /reload) |
 
 ### Prometheus ServiceMonitor
 

diff --git a/helm/templates/deployment.yaml b/helm/templates/deployment.yaml
@@ -53,7 +53,11 @@ spec:
             {{- toYaml .Values.securityContext | nindent 12 }}
           image: "{{ .Values.image.repository }}:{{ default .Chart.AppVersion .Values.image.tag }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
-          args: ["-config.file=/etc/sql_exporter/sql_exporter.yml"]
+          args:
+            - "-config.file=/etc/sql_exporter/sql_exporter.yml"
+            {{- if .Values.reloadEnabled }}
+            - "-web.enable-reload"
+            {{- end }}
           {{- if eq (include "sql-exporter.volumes" .) "\"true\"" }}
           volumeMounts:
           {{- if .Values.createConfig }}

diff --git a/helm/values.yaml b/helm/values.yaml
@@ -117,6 +117,8 @@ serviceMonitor:
 #       mountPath: /etc/config
 # Set to true to create a config as a part of the helm chart
 createConfig: true
+# -- Enable reload collector data handler (endpoint /reload)
+reloadEnabled: false
 config:
   global:
     # -- Scrape timeout