fix: error type conversion (#353)

burningalchemist · Oct 8, 2023 · 7f9f26b · 7f9f26b
1 parent 0875aea
commit 7f9f26b
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/cmd/sql_exporter/promhttp.go b/cmd/sql_exporter/promhttp.go
@@ -42,19 +42,23 @@ func ExporterHandlerFor(exporter sql_exporter.Exporter) http.Handler {
 		gatherer := prometheus.Gatherers{exporter.WithContext(ctx)}
 		mfs, err := gatherer.Gather()
 		if err != nil {
+			switch t := err.(type) {
+			case prometheus.MultiError:
+				for _, err := range t {
+					if errors.Is(err, context.DeadlineExceeded) {
+						klog.Errorf("%s: timeout collecting metrics", err)
+					} else {
+						klog.Errorf("Error gathering metrics: %s", err)
+					}
+				}
+			default:
+				klog.Errorf("Error gathering metrics: %s", err)
+			}
 			if len(mfs) == 0 {
 				klog.Errorf("%s: %s", noMetricsGathered, err)
 				http.Error(w, noMetricsGathered+", "+err.Error(), http.StatusInternalServerError)
 				return
 			}
-			multierr := err.(prometheus.MultiError)
-			for _, err := range multierr {
-				if errors.Is(err, context.DeadlineExceeded) {
-					klog.Errorf("%s: timeout collecting metrics", err)
-				} else {
-					klog.Errorf("Error gathering metrics: %s", err)
-				}
-			}
 		}
 
 		contentType := expfmt.Negotiate(req.Header)