Fixes to support WASI on Zephyr #3948
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issues in os_renameat Signed-off-by: Stephen Berard <[email protected]>
srberard
requested review from
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
|
There is 1 testing failing above, but I don't believe it's related to this PR. |
It's not related. Don't be worried. |
lum1n0us
reviewed
Dec 6, 2024
|
|
||
| char *path = strdup(new_path); | ||
| if (path == NULL) { | ||
| return __WASI_ENOMEM; |
There was a problem hiding this comment.
In before, if strdup() returns NULL, ptr->path will be set to old_path instead of maintaining original value. But in after, it's not. So, is it on purpose?
lum1n0us
reviewed
Dec 6, 2024
| return __WASI_ENOMEM; | ||
| } | ||
|
|
||
| free(ptr->path); |
There was a problem hiding this comment.
just to be sure, IIUC, the core idea of this patch is to free(ptr->path) before assigning a new value. Is that correct?
wenyongh
reviewed
Dec 10, 2024
| * To manage our file descriptors, we created a struct `zephyr_fs_desc` that | ||
| * represent a zephyr file descriptor and hold useful informations. | ||
| * We also created a file descriptor table to keep track of all the file | ||
| * To manage our file descriptors, we a struct `zephyr_fs_desc` is created that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues #3311.
@wenyongh I'm merging this to the branch created so that we can review and ensure all the items are addressed prior to merging back to main.