Automatically manage pre-release branches #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrutlucian94
force-pushed
the
lpetrut/auto-pre-release
branch
10 times, most recently
from
397710f to
6b98e4d
Compare
petrutlucian94
force-pushed
the
lpetrut/auto-pre-release
branch
2 times, most recently
from
2874132 to
9ee419a
Compare
A k8s-snap PR automatically creates and cleans up git branches for upstream k8s pre-releases: canonical/k8s-snap#916 Here we're adding an almost identical job that picks up these git branches and prepares launchpad recipes. TODOs: * clean up obsolete pre-releases that were superseeded by a new pre-release or stable release * promote beta and rc pre-releases to the corresponding snap risk level
petrutlucian94
force-pushed
the
lpetrut/auto-pre-release
branch
from
9ee419a to
43c945c
Compare
We intend to publish snaps for pre-release branches, which have the following format: auotupdate/v1.33.0-alpha.1. In order to do so, we need to update the "TIP_BRANCH" regex, which is used to filter branches. We'll need to clarify what "TIP_BRANCH" means and add an inline comment.
petrutlucian94
force-pushed
the
lpetrut/auto-pre-release
branch
2 times, most recently
from
9bcc19e to
e2ac086
Compare
petrutlucian94
force-pushed
the
lpetrut/auto-pre-release
branch
from
e2ac086 to
ee96d92
Compare
bschimke95
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Great work @petrutlucian94
Looks great already, only some small changes.
* use argparse * reneame k8s_releases.py -> k8s_release.py * move cleanup placeholder
petrutlucian94
force-pushed
the
lpetrut/auto-pre-release
branch
from
c7f2428 to
e08351d
Compare
We'll use a single branch for all pre-releases of a given risk level, e.g. v1.33.0-alpha.0 -> autoupdate/v1.33.0-alpha. This commit also removes unused k8s_release.py functions that were inherited from the k8s-snap script.
petrutlucian94
force-pushed
the
lpetrut/auto-pre-release
branch
from
e08351d to
f4ef36f
Compare
|
@bschimke95 The promotion CI failures are unrelated, should we merge this PR to get it out the way? |
|
let's do this. |
bschimke95
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A k8s-snap PR automatically creates and cleans up git branches for upstream k8s pre-releases:
canonical/k8s-snap#916
Here we're adding an almost identical job that picks up these git branches and prepares launchpad recipes.
TODOs: