Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rockcraft specs for cilium and cilium-operator-generic 1.16.5. #14

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aznashwan
Copy link

No description provided.

@aznashwan aznashwan requested a review from a team as a code owner December 19, 2024 16:00
@aznashwan
Copy link
Author

There seems to be a known compilation issue in one one of envoy's dependencies (google/cel-cpp) which has been fixed in this PR.

Unfortunately, I was not able to find a sane way to patch in the fix since there's literally 3 layers of build shenanigans going on (cilium/cilium builds cilium/proxy which builds envoyproxy/envoy which depends on that unbuildable google/cel-cpp)

I have tried patching in the envoy commit ID which should include the dependency update with the fix but it unfortunately doesn't seem to work properly.

There's also this cilium/proxy ENVOY_VERSION file with the tag for the envoyproxy/envoy repo tag used in some (but not all!) build stages, but there's yet not a single tag on envoyproxy/envoy which features that fix (it has to be an actual SemVer-format release tag, so we can't just put main there sadly).

At this stage, I do not believe there's anything we could do but wait for:

  • envoyproxy/envoy to add that commit with the google/cel-cpp version bump to be pushed to a proper release tag
  • cilium/proxy to update their ENVOY_VERSION and bazel build config with the proper tag/commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant