-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a charm action to run wp core update db after a wordpress upgrade #235
Create a charm action to run wp core update db after a wordpress upgrade #235
Conversation
…t kind of tests I need to write.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Some comments.
Wouldnt that be the case of adding this to the _on_upgrade_charm event instead of a manual action? When running with --dry-run wouldn't be possible to check if is needed or not? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should discuss what to do when db-update fails, otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5d2eee5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test coverage for 5d2eee5
Static code analysis report
|
Added an action for updating database.
NEED ADVICE: I did not check the boxes regarding documentation because I am not sure if I need to update the documentation and how to do that.
Overview
After updating the WordPress version we have to update the database and there was no action for it. This PR creates an action for that called 'update-database'.
Rationale
After updating the WordPress version we have to update the database and there was no action for it.
User had to ssh into the container to do that.
Juju Events Changes
Module Changes
Library Changes
Checklist
src-docs
urgent
,trivial
,complex
)