Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ComboBox to use useComboBox instead of <Downshift> component #14684

Closed
Tracked by #6102
tay1orjones opened this issue Sep 19, 2023 · 0 comments · Fixed by #16283
Closed
Tracked by #6102

Refactor ComboBox to use useComboBox instead of <Downshift> component #14684

tay1orjones opened this issue Sep 19, 2023 · 0 comments · Fixed by #16283
Assignees
@tay1orjones @tw15egan @preetibansalui
Labels
component: combobox proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Sep 19, 2023 •
edited
Loading

Downshift plans to move forward with their React Hooks API and deprecate and remove <Downshift> from the API:

We need to refactor our ComboBox to no longer use <Downshift> and instead use the useComboBox hook. As part of this we'll need to ensure downstream consumers aren't impacted at all and nothing of significance changes. If we can't contain this without a breaking change, we'll need to put the refactor behind a feature flag (using the same component name) and slate it for v12.
@tay1orjones tay1orjones mentioned this issue Sep 19, 2023
Open
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Sep 19, 2023
@tay1orjones tay1orjones added the proposal: accepted This request has gone through triaging and we are accepting PR's against it. label Sep 19, 2023
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Sep 19, 2023
This was referenced Sep 19, 2023
Closed
Closed
@tay1orjones tay1orjones moved this from Triage to Next in Roadmap Sep 19, 2023
@tay1orjones tay1orjones added this to the 2023 Q4 milestone Sep 19, 2023
@tay1orjones tay1orjones changed the title Refactor ComboBox to use useComboBox instead of <Downshift> Refactor ComboBox to use useComboBox instead of <Downshift> component Sep 19, 2023
@tay1orjones tay1orjones moved this from Next to Now in Roadmap Oct 2, 2023
@tay1orjones tay1orjones modified the milestones: 2023 Q4, 2024 Q1 Dec 13, 2023
@alisonjoseph alisonjoseph removed their assignment Dec 13, 2023
@tay1orjones tay1orjones mentioned this issue Mar 6, 2024
Closed
@tay1orjones tay1orjones moved this from ⏱ Backlog to 🏗 In Progress in Design System Mar 13, 2024
@tay1orjones tay1orjones modified the milestones: 2024 Q1, 2024 Q2 Apr 3, 2024
@preetibansalui preetibansalui mentioned this issue Apr 30, 2024
Merged
@github-project-automation github-project-automation bot moved this from Now to Completed in Roadmap May 10, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in Design System May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tay1orjones tay1orjones

@tw15egan tw15egan

@preetibansalui preetibansalui

Labels
component: combobox proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡
Projects
Design System
Archived in project
Roadmap
Archived in project
Milestone
No milestone
4 participants
@alisonjoseph @tay1orjones @tw15egan @preetibansalui