Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align markup syntax with vscode #58

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

uncenter
Copy link
Member

@uncenter uncenter commented Jan 5, 2025

  • Adjusts the numbered markup.heading colors to align with VSCode's numbered markdown heading colors, and removed the markup.heading.marker styling that should instead by supplied by the numbered markup.heading capture. This technically depends on Improve markdown heading highlights helix-editor/helix#12417 upstream at Helix.
Before After VS Code
CleanShot 2025-01-05 at 15 56 41 CleanShot 2025-01-05 at 15 46 29 CleanShot 2025-01-05 at 15 59 59
  • Changes markup.list from mauve to teal (numbered lists in markdown such as 1. foo 2. bar).
Before After VS Code
CleanShot 2025-01-05 at 15 56 09 CleanShot 2025-01-05 at 15 44 26 CleanShot 2025-01-05 at 15 59 26
  • markup.bold and markup.italic are now red as well as their previous styles (italic and bold text ofc).
Before After VS Code
CleanShot 2025-01-05 at 15 55 06 CleanShot 2025-01-05 at 15 43 26 CleanShot 2025-01-05 at 15 58 35
  • markup.link.text, the title of links in markdown, is now lavender instead of blue.
Before After VS Code
CleanShot 2025-01-05 at 15 55 32 CleanShot 2025-01-05 at 15 44 56 CleanShot 2025-01-05 at 16 00 27
  • markup.raw is green instead of flamingo.
Before After VS Code
CleanShot 2025-01-05 at 15 57 07 CleanShot 2025-01-05 at 15 45 58 CleanShot 2025-01-05 at 16 01 30

@uncenter
Copy link
Member Author

uncenter commented Jan 5, 2025

  • Add new entry for markup.quote that sets it to pink.
Before After VS Code
CleanShot 2025-01-05 at 16 09 57 CleanShot 2025-01-05 at 16 09 10 CleanShot 2025-01-05 at 16 10 12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant