This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Add support for Cumulative API #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
draffensperger and
justindsmith
as code owners
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
=========================================
+ Coverage 94.74% 94.84% +0.1%
=========================================
Files 148 150 +2
Lines 9946 10106 +160
Branches 747 752 +5
=========================================
+ Hits 9423 9585 +162
+ Misses 523 521 -2
Continue to review full report at Codecov.
|
draffensperger
approved these changes
Apr 9, 2019
| * @param {number} val The new value. | ||
| */ | ||
| inc(val?: number): void { | ||
| if (val && !Number.isFinite(val)) { |
There was a problem hiding this comment.
Does this catch NaN (I'm guessing not), and assuming not, could you make it do that?
draffensperger
approved these changes
Apr 10, 2019
mayurkale22
force-pushed
the
cumulative_api
branch
from
161ac4d to
6444d01
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #450
Adding Derived Cumulative API and registering with Metric-Registry will be in a follow-up PR.