-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RPC Measure and View Constants #884
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
We mistakenly closed this pull request to rebase our project with the current version of OpenCensus, but were able to fix the issue! |
@googlebot I signed it! |
@googlebot I fixed it. |
Hi all involved, my name's Chris Dietsch (MSFT alias chdietsc) and I was the Microsoft sponsor for this project which was a university senior design project. Today was the handoff for this project since they're graduating. I want to help figure out how best to manage getting this merged in, since the CLAs show as needing their help but I can't rely on their availability since this is technically outside of their semester now. I'll take a look at the test failures now. Thanks, |
@aasiyahf It looks like your NCSU account made the commit. Couple ideas here:
If I'm reading the circleci failure correctly, is this a lint error failure? |
I'm going to attempt resolving some of these issues by opening a separate pull request. |
We (myself and @anamnavi) have been working on resolving issue #276 alongside Microsoft's Quantum Computing Team for code review, quality control, etc. in relation to RPC zpages written in Python.
As per the requirements of the opencensus specs document, we implemented the RPC View and Measure Constants. You can find them within opencensus/grpc under the names rpc_measure_constants.py and rpc_view_constants.py. We have included test files under the names rpc_m_c_test.py and rpc_v_c_test.py, respectively.
For further inquiry, you can reach me at [email protected] or [email protected] and @anamnavi at [email protected] or [email protected].