cefsrc: Clean up CEF object refs #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were never setting src->app, so I removed it from the struct... Also I added the BrowserClient to _GstCefSrc, so that I could try and ensure it is getting dereferenced.
| @@ -967,6 +967,8 @@ gst_cef_src_stop (GstBaseSrc *base_src) | |||
| { | |||
| GstCefSrc *src = GST_CEF_SRC (base_src); | |||
|
|
|||
| GST_OBJECT_LOCK (src); | |||
There was a problem hiding this comment.
Why is this needed? Taking the object lock then waiting is a bit awkward, it could mean an for instance an application potentially blocking while trying to set a property from its main thread
I think it would be best to first check with upstream before adding workarounds in the element. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First raised here - #90 (comment) - I am seeing some buffer corruption in the first
OnPaintcall when running multiple cefsrc elements.It's not super deterministic, but looks like this:
with the next frame being a successful paint:
I think the issue is possibly a CEF one (see https://magpcss.org/ceforum/viewtopic.php?f=6&t=18906), but this branch is me trying to improve the Cef object cleanup (to no avail - doesn't fix the issue, but pushing to get your thoughts).
I wonder if we should just drop the first frame / OnPaint call?
Commit msg:
We were never setting src->app, so I removed it from the struct... Also I added the BrowserClient to _GstCefSrc, so that I could try and ensure it is getting dereferenced.