Disqualify conflicts with self for packages #1415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
approved these changes
Nov 22, 2024
Previously, we called disqualifyConflicts to disqualify any packages that would conflict with whatever package we selected. This made it possible to pick multiple packages with the same name, which we'd then deduplicate and end up with whatever the first package was. That's unexpected and produced solutions that were missing a package in a few corner cases, mostly caused by old packages (in wolfi) providing things accidentally that weren't withdrawn. I've manually tested this change against our large corpus of images and nothing failed to solve. Signed-off-by: Jon Johnson <[email protected]>
jonjohnsonjr
force-pushed
the
dq-self
branch
from
febe67a to
e4f8067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we called disqualifyConflicts to disqualify any packages that would conflict with whatever package we selected. This made it possible to pick multiple packages with the same name, which we'd then deduplicate and end up with whatever the first package was. That's unexpected and produced solutions that were missing a package in a few corner cases, mostly caused by old packages (in wolfi) providing things accidentally that weren't withdrawn.
I've manually tested this change against our large corpus of images and nothing failed to solve.