-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Support bold ANSI escape sequence #154
base: main
Are you sure you want to change the base?
Conversation
Awesome, thanks for the PR. One question: why |
@meowgorithm Maybe my machine is rendering fonts strangely, but bold doesn't look very different than regular text, so I was trying to make the effect more obvious. Would you prefer bold? That might make more sense |
@gabe565 can you render to PNG and post the results here? SVGs render differently depending on device (for example, the SVGs above look different on my phone versus my desktop).
In other words, given than 400 (regular) is the default weight,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than using "bold"
, looks good 🙂
Thanks for the insight, I hadn't thought about rendering handled when a 500 weight font wasn't available. For some reason PNG rendering doesn't work on my machine, so let me try it in a container. I'm curious to see the difference |
ce5688b
to
a35b9da
Compare
The code to print bold text is currently commented out, even though it works fine. This PR uncomments it to add support for rendering bold text.
I also noticed that bold text wasn't very pronounced, so I changed the
font-weight
tobolder
. If this is undesired, just let me know and I can remove that change.Before:
After (with
font-weight="bold"
):After (with
font-weight="bolder"
):I also noticed the bold
Fixes #75