Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oid pointer relative path #20

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix: oid pointer relative path #20

merged 1 commit into from
Oct 27, 2023

Conversation

aymanbagabas
Copy link
Member

@aymanbagabas aymanbagabas commented Oct 27, 2023

The specs define the relative path as $GIT_DIR/lfs/objects/{OID[0:2]/OID[2:4]/OID}

The [specs](https://github.com/git-lfs/git-lfs/blob/main/docs/spec.md)
define the relative path as lfs/objects/{OID[0:2]/OID[2:4]/OID}
@aymanbagabas
Copy link
Member Author

cc/ @KyleFromKitware

@codecov
Copy link

codecov bot commented Oct 27, 2023

We're currently processing your upload. This comment will be updated when the results are available.

@KyleFromKitware
Copy link
Contributor

+1, though I am not personally using the local backend so I haven't tried it.

@aymanbagabas aymanbagabas merged commit 7aa2d62 into master Oct 27, 2023
14 checks passed
@aymanbagabas aymanbagabas deleted the relative-path branch October 27, 2023 15:09
@aymanbagabas
Copy link
Member Author

+1, though I am not personally using the local backend so I haven't tried it.

The local backend is used for testing. I'm planning on adding the ability to specify a custom backend using the git-lfs-transfer binary and shell scripts

@KyleFromKitware
Copy link
Contributor

I'm planning on adding the ability to specify a custom backend using the git-lfs-transfer binary and shell scripts

Not a bad feature, though I think for GitLab we're still going to use the Go library directly, because it integrates so nicely into gitlab-shell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants