Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Trigger characters not working after a new space (Shift+Enter) #32

Merged
merged 4 commits into from
Sep 6, 2024
Merged

fix: Trigger characters not working after a new space (Shift+Enter) #32

merged 4 commits into from
Sep 6, 2024

Conversation

iamsivin
Copy link
Member

@iamsivin iamsivin commented Sep 6, 2024 •
edited
Loading

This PR will fix an issue with triggerCharacters function, that it's not triggering on a new space added by shift+enter keys

Changes

  1. Reverted some of the changes to older one https://github.com/chatwoot/prosemirror-schema/pull/30/files#diff-ec5844affb3648ec894381be74366ccce7ec19a93e5cc5d3196b04ad49bedbbcL9
  2. Updated the regex

@iamsivin iamsivin requested a review from muhsin-k September 6, 2024 06:13
@iamsivin iamsivin merged commit c3540b9 into main Sep 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhsin-k muhsin-k muhsin-k approved these changes

Assignees

@muhsin-k muhsin-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamsivin @muhsin-k