feat: Add priorityClassName to deployment #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbabysre
requested review from
ibuziuk,
SDawley,
tolusha and
dkwon17
as code owners
|
Click here to review and test in web IDE: |
|
Also i've noticed that this would not add a priorityClassName to the DaemonSet pods, i'll be happy to help implement this feature if it's something that could be useful |
tolusha
reviewed
Jan 7, 2025
| repository: quay.io/eclipse/kubernetes-image-puller | ||
| tag: next | ||
| serviceAccount: | ||
| name: k8s-image-puller | ||
| priorityClassName: {} |
There was a problem hiding this comment.
Suggested change
| priorityClassName: {} | |
| priorityClassName: "" |
Could you try this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone !
I've read the Opensource guide on how to make contribution and felt that a Pull Request was the correct way to implement this as an Issue was maybe a bit too much, i hope i did things correctly.
I'm opening a PR to add a feature to the deployment :
This feature adds the following
Let me know if this is the correct way to do so.