Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first commit #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: first commit #1

wants to merge 2 commits into from

Conversation

lpatiny
Copy link
Member

@lpatiny lpatiny commented Dec 18, 2024

No description provided.

@lpatiny
Copy link
Member Author

lpatiny commented Dec 18, 2024

@targos I got inspired by your workers-manager project to create this project.

This code is expected to be compatible with the browser and in node. My build seems to work but I didn't push very far my tests.

To test the speed I have a 350 Mb file containing 11000 base64 compressed data. Using this library and the code:

https://github.com/cheminfo/parallel-workers-manager/pull/1/files#diff-a96f6482139689d016984954d51fd6b1241d889ffd8ccdd45e894f80e9942870

I go from 3s to 0.7s. I didn't see any improvements using transferable objects but didn't test much further.

I will test if I can use openchemlib/core as well

Any comments on this library ?

@targos
Copy link
Member

targos commented Dec 19, 2024

I'll have a closer look when I have time, but the fact that it's using fn.toString makes it quite limited. You can only use it with standalone functions, no?

@lpatiny
Copy link
Member Author

lpatiny commented Dec 19, 2024

Yes we can discuss this together next year but indeed I use rollup to combine all the code as one function to be able to use this library. Need to think if this is a sustainable way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants