Switch to special use foreground service type #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrapheneOS 14 introduced [1], which unconditionally changes the system exempted foreground type to the special use foreground type within `ServiceInfo`. This applies to all packages, not just gmscompat-related packages. However, they don't wrap the corresponding `startForeground()` calls, so the mismatch causes Custota's service to crash. We can work around this GrapheneOS bug by switching to the special use foreground type, which currently has no downsides compared to the system exempted foreground type. Fixes: #22 [1]: GrapheneOS/platform_frameworks_base@a350b31 Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
force-pushed
the
grapheneos
branch
from
03247c8 to
a875dda
Compare
chenxiaolong
added a commit
that referenced
this pull request
Oct 16, 2023
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GrapheneOS 14 introduced 1, which unconditionally changes the system exempted foreground type to the special use foreground type within
ServiceInfo. This applies to all packages, not just gmscompat-related packages.However, they don't wrap the corresponding
startForeground()calls, so the mismatch causes Custota's service to crash. We can work around this GrapheneOS bug by switching to the special use foreground type, which currently has no downsides compared to the system exempted foreground type.Fixes: #22