Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Add ability for files to check to continue a space #2

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This change adds the ability to still run files that include a space in
their filename through language server.

Motivation and Context

Without this change, any file that contains a space in their name makes
the action fail.

Testing

  1. Tested in my own personal repositories.
  2. Not found a way to test this locally.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A

@AdmiringWorm AdmiringWorm self-assigned this Oct 18, 2023
@AdmiringWorm AdmiringWorm requested a review from pauby October 18, 2023 08:39
This change adds the ability to still run files that include a space in
their filename through language server.

Without this change, any file that contains a space in their name makes
the action fail.
@pauby pauby merged commit ab20ce3 into chocolatey:develop Nov 8, 2023
7 checks passed
@pauby
Copy link
Member

pauby commented Nov 8, 2023

@AdmiringWorm awesome work! Thanks for your contribution!

@AdmiringWorm AdmiringWorm deleted the file-spaces branch February 12, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants