Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add es module #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions index.es.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import assert from 'www.unpkg.com/nanoassert?module'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a protocol?

Copy link
Member Author

@YerkoPalma YerkoPalma Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this?

import assert from 'https://www.unpkg.com/nanoassert?module'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea. actually, doesn't unpkg automatically rewrite import paths when you use ?module? just doing import assert from 'nanoassert' might just work already.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't .Something like https://unpkg.com/md?module get resolved to https://unpkg.com/[email protected]/dist/md.es.js?module which is the actual version plus whatever you defined in your module property in package.json

Copy link
Member

@goto-bus-stop goto-bus-stop Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean how the import statements in the package source code get rewritten, like this:
image

so if we do import assert from 'nanoassert' here, unpkg would turn it into import assert from 'https://unpkg.com/[email protected]/index.js?module' automatically. bundlers could also use this entry point then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you mean when already published? Actually never tried that, it would be much cleaner.


var placeholder = {
cancel: noop,
finish: noop,
pause: noop,
play: noop,
reverse: noop,
finished: {
then: Promise.resolve // Animations can be chained with promises or property definitions
}
}

export default function animate (keyframes, timingProperties) {
assert.equal(typeof keyframes, 'object', 'nanoanimation: keyframes should be an array or an object')
assert.ok(typeof timingProperties === 'object' || typeof timingProperties === 'number', 'nanoanimation: timingProperties should be type object or number')

return function (element, _done) {
var done = _done || noop
assert.equal(typeof element, 'object', 'nanoanimation: element should be type object')
assert.equal(typeof done, 'function', 'nanoanimation: done should be type function')

if (typeof window === 'undefined' || !('AnimationEvent' in window)) {
done()
return placeholder
}

var animation = element.animate(keyframes, timingProperties)
animation.pause()
animation.onfinish = done
return animation
}
}

function noop () {}
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
"description": "Safety wrapper around the Web Animation API",
"repository": "choojs/nanoanimation",
"version": "2.1.0",
"main": "index.js",
"module": "index.es.js",
YerkoPalma marked this conversation as resolved.
Show resolved Hide resolved
"scripts": {
"deps": "dependency-check . && dependency-check . --extra --no-dev",
"start": "node .",
Expand Down