-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add es module #7
Open
YerkoPalma
wants to merge
4
commits into
master
Choose a base branch
from
module
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
import assert from 'www.unpkg.com/nanoassert?module' | ||
|
||
var placeholder = { | ||
cancel: noop, | ||
finish: noop, | ||
pause: noop, | ||
play: noop, | ||
reverse: noop, | ||
finished: { | ||
then: Promise.resolve // Animations can be chained with promises or property definitions | ||
} | ||
} | ||
|
||
export default function animate (keyframes, timingProperties) { | ||
assert.equal(typeof keyframes, 'object', 'nanoanimation: keyframes should be an array or an object') | ||
assert.ok(typeof timingProperties === 'object' || typeof timingProperties === 'number', 'nanoanimation: timingProperties should be type object or number') | ||
|
||
return function (element, _done) { | ||
var done = _done || noop | ||
assert.equal(typeof element, 'object', 'nanoanimation: element should be type object') | ||
assert.equal(typeof done, 'function', 'nanoanimation: done should be type function') | ||
|
||
if (typeof window === 'undefined' || !('AnimationEvent' in window)) { | ||
done() | ||
return placeholder | ||
} | ||
|
||
var animation = element.animate(keyframes, timingProperties) | ||
animation.pause() | ||
animation.onfinish = done | ||
return animation | ||
} | ||
} | ||
|
||
function noop () {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs a protocol?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea. actually, doesn't unpkg automatically rewrite import paths when you use
?module
? just doingimport assert from 'nanoassert'
might just work already.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't .Something like
https://unpkg.com/md?module
get resolved tohttps://unpkg.com/[email protected]/dist/md.es.js?module
which is the actual version plus whatever you defined in your module property in package.jsonThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean how the
import
statements in the package source code get rewritten, like this:so if we do
import assert from 'nanoassert'
here, unpkg would turn it intoimport assert from 'https://unpkg.com/[email protected]/index.js?module'
automatically. bundlers could also use this entry point then.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you mean when already published? Actually never tried that, it would be much cleaner.