-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export records from tables #1646
Open
johnclary
wants to merge
16
commits into
john/20202-page-and-record-counts
Choose a base branch
from
john/20456-record-export
base: john/20202-page-and-record-counts
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Export records from tables #1646
johnclary
wants to merge
16
commits into
john/20202-page-and-record-counts
from
john/20456-record-export
+242
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnclary
commented
Jan 6, 2025
// update the provided query with export settings | ||
return produce(queryConfig, (newQueryConfig) => { | ||
// reset limit and offset | ||
newQueryConfig.limit = MAX_RECORD_EXPORT_LIMIT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hasura will accept a limit
of null
, but modifying this typing to accept null
was a headache i didn't really want to deal with 🤷
johnclary
requested review from
mateoclarke,
frankhereford,
chiaberry,
tillyw,
roseeichelmann and
mddilley
January 6, 2025 19:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated issues
This PR adds a basic CSV export to the grid table. I decided to hold off on some more sophisticated functionality, which can be addressed via cityofaustin/atd-data-tech#20481. The main thing this export does not do versus the old VZE is allow exporting related records. That will require some bigger changes to the structure of the
queryConfig
and thequeryBuilder
.See also some discussion here about the style of the pagination + record counts 👀
Testing
URL to test: Local
Steps to test:
These tables are now exportable:
Ship list
main
branch