v3.1.2 #252
Open
v3.1.2 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DESCRIPTION: patch update to v3.0.1 + add Peter as maintainer * deprecate the "local" argument in CivisFuture() and future:Future() * rebuild documentation * DEP remove @inheritParams from fetch_output() * Update CHANGELOG.md * use `deprecate_soft` instead of `deprecate_warn` * move lifecycle dependency to Suggests * ignore all civis.Rcheck files * explicitly document "local" argument to CivisFuture() * split "x" and "newdata" documentation in civis_ml() * re-build default client * Revert "re-build default client" This reverts commit 7e4e785. * run generate_default_client.R * run fetch_and_generate_client() * Revert "run fetch_and_generate_client()" This reverts commit 697e592. * Revert "run generate_default_client.R" This reverts commit dcd5690. * update documentation * change version to minor update (v3.1.0) * Update CHANGELOG.md
* generate new default client * remove new API endpoints * missed some new API endpoints * re-adding queries_delete_runs() * Revert "re-adding queries_delete_runs()" This reverts commit 3e76458. * Revert "missed some new API endpoints" This reverts commit 360524f. * Revert "remove new API endpoints" This reverts commit e44c815. * Revert "generate new default client" This reverts commit 3331f1c. * remove deprecated API endpoints * update links * add new generated default client
…cs/civis-r into prep_release_v3.1.0
* Patch fetch_all pagination helper The `fetch_all` function is intended to call `fetch_until` until a result of `FALSE` is returned. However, when the API returns no result, that output manifests as a NULL, not a boolean `FALSE` value. This change prevents a coercion error of trying to boolean compare a NULL value in R. * ADD Bryan Baird as a contributor * Update DESCRIPTION --------- Co-authored-by: pcooman <[email protected]>
…cs/civis-r into prep_release_v3.1.0
* DEP set future$state to "finished" if API job "succeeded" * increment version to v3.1.1
mheilman
requested changes
Dec 6, 2023
CRAN-SUBMISSION
Outdated
| @@ -0,0 +1,3 @@ | |||
| Version: 3.1.0 | |||
There was a problem hiding this comment.
I think this should be removed and put in the .gitignore. See https://stackoverflow.com/a/72631281. It doesn't seem unreasonable to leave it in, but this particular file is out of date.
.gitignore
Outdated
| @@ -9,3 +9,6 @@ inst/web | |||
| .*.swp | |||
| .*.swo | |||
| .DS_Store | |||
| civis.Rcheck/ | |||
| /doc/ | |||
There was a problem hiding this comment.
I'm confused that /doc/ is listed here but this PR adds a bunch of files in that directory. Should this be doc/ and meta/?
At any rate, I think Meta/vignette.rds and doc/* should be removed from this branch and squashed away when merging.
cran-comments.md
Outdated
| @@ -0,0 +1,17 @@ | |||
| ## R CMD check results | |||
There was a problem hiding this comment.
I think this file should be deleted and added to .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging in this branch, which has already been deployed to CRAN