upstream upgrade #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding logging for debugging slave lag
Set the license to New BSD
'BSD-3-Clause' is less ambiguous than 'New BSD' and it's also the url slug used by the opensource.org URL http://opensource.org/licenses/BSD-3-Clause
Add license information to lhm.gemspec
The chunker does not require an auto_increment column, it simply requires an integer column in order to find the start/limit of the table. Relax the migrator/table checks to only look for an `id` INT column. * Add support for BIGINT `id` columns * Add fixture for BIGINT `id` column * Add test for BIGINT `id` columns * Add fixture for "broken" varchar `id` column * Update specs * Update README with changes, and note about sparse `id` data
Update chunker requirements
…opment-gems Running tests requires active_record and mysql
We are seeing:
== SomeHorriblyLongMigrationInvolvingTablesWithNamesFarTooLongForHumanBeingsToConsiderReasonable: migrating
I, [2015-07-15T12:07:08.972714 #47706] INFO -- : Starting LHM run on table=lhmn_tables_with_names_far_too_long_for_human_beings_to_consider
I, [2015-07-15T12:07:08.972868 #47706] INFO -- : Starting run of class=Lhm::Migrator
I, [2015-07-15T12:07:09.012700 #47706] INFO -- : Starting run of class=Lhm::Entangler
E, [2015-07-15T12:07:09.015775 #47706] ERROR -- : Error in class=Lhm::Entangler, reverting. exception=ActiveRecord::StatementInvalid message=Mysql2::Error: Identifier name 'lhmt_del_tables_with_names_far_too_long_for_human_beings_to_consider_reasonable' is too long: create trigger `lhmt_del_tables_with_names_far_too_long_for_human_beings_to_consider_reasonable`
...
It looks like this has already been faced in the migrator:
def archive_name
"lhma_#{ startstamp }_#{ @origin.name }"[0...64]
end
So let's truncate here as well.
…r-names Truncate long trigger names
`cleanup(:run)` is more self-explanatory than `cleanup(true)`.
…gle_row_when_the_id_is_not_1_sc_master Adding failing test and fix for potential data destruction
Improve readability of cleanup method calls
Remove extra `a`
Fix a minor typo in Readme
Add example in README for setting default values
Add test to check no line is forgotten when copying 5 lines with stride 2
…nker Fix chunker for forgotten lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge from #2 but from a branch and with whatever travis changes are necessary.