-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference string-conversions in README. #7
base: master
Are you sure you want to change the base?
Conversation
Thanks. I don't think the README's scope should include enumerating alternatives. That can quickly become out of date and puts an extra burden on the maintainers. |
I also think this PR is wrong.
Emphasis mine. |
I disagree with you @aztecrex. At least in this instance the reference will not get out of date any time soon, and even if it would its value would still be enormous. I've been happily using and recommending
I may still be wrong and explicitly returning errors in the type may be objectively better. Anyway, feel free to keep this closed, I'm just trying to help. :-) Thanks again! |
Oh, I only just noticed I pressed the “close and comment” button instead of the “comment” button when I left my comment earlier. It was not intentional; I apologize for coming off as unnecessarily aggressive! It looks like you’re right that In any case, I’ll reopen this and let the current maintainers decide what to do with it; I do not work at CJ anymore, and I don’t have the spare cycles to be a good maintainer right now. :) |
no offense taken, and i don't mind this PR getting rejected, even though i would prefer to add yes, maintainers, please make a call. |
See also: soenkehahn/string-conversions#14
If you disagree with the "matter of taste" thing I'd be very interested in your opinion. :-)
For what it's worth I think I am going to trade string-conversions with text-conversions. It's a little more explicit, means more work to write code and less work to read it. Always a good thing!
Thanks for this, and for your great blog that led me here!