Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support optional infra cluster via feature flag #147

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

phoban01
Copy link
Contributor

@phoban01 phoban01 commented Nov 7, 2024

Description

Support was added for the controlPlaneEndpoint field in #137.

This PR builds upon that work to support making the infrastructure cluster fully optional.

We do this by introducing a feature flag SkipInfraClusterPatch that when enabled will bypass patching of the infrastructure cluster.

@phoban01 phoban01 force-pushed the support-nil-infra-provider branch from 7eaf63a to a51d259 Compare November 7, 2024 11:35
@prometherion
Copy link
Member

LGTM, it's something I was thinking of with that support.

May I ask you to commit some changes to enable this feature using env vars as we're doing with the external cluster reference?

- --feature-gates=ExternalClusterReference=${CACPPK_EXTERNAL_CLUSTER_REFERENCE:=false},ExternalClusterReferenceCrossNamespace=${CACPPK_EXTERNAL_CLUSTER_REFERENCE_CROSS_NAMESPACE:=false}

@phoban01
Copy link
Contributor Author

phoban01 commented Nov 7, 2024

@prometherion I've added the envvar to the manager.yaml.

I think control-plane-components.yaml should be generated/updated as part of a release right?

nvm, I see there's a CI check.

Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, happy for the contribution, thanks a lot!

@prometherion prometherion merged commit b3d2f9c into clastix:master Nov 7, 2024
4 checks passed
@phoban01 phoban01 deleted the support-nil-infra-provider branch November 7, 2024 14:18
@prometherion prometherion added this to the v0.13.0 milestone Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants