-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split binaries #2011
base: master
Are you sure you want to change the base?
Split binaries #2011
Conversation
e1cfc8b
to
3c2be0c
Compare
} | ||
proxy::run_cli(&paths, None, cli_args) | ||
} | ||
_ => unimplemented!(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the idea that we'll implement these in another PR? Note that spacetimedb upgrade
is already a thing. We probably want to remove that with that PR.
3c2be0c
to
699d806
Compare
Needs PR description according to template. |
PR description should include what the correct way for a reviewer to invoke the CLI is now. In the past I've been doing I also notice that you've updated the smoketests to invoke the inner |
d3fee57
to
302d7d2
Compare
Description of Changes
Resolves #1838
Adds a
spacetimedb-update
multicall binary that proxies tospacetimedb-cli
, and makesspacetime run
call out to thespacetimedb-standalone
binary instead of embedding the whole server in the cli. Functionality for theupdate
binary itself forthcoming in another PR.Expected complexity level and risk
3 - adds the proxy binary and changes how
run
works under-the-hood, but the deeper changes will come in the follow-up.Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!
spacetimedb-update
proxied to the cli binary.