Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency twing-loader to v4 #1347

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 28, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
twing-loader 3.0.1 -> 4.0.0 age adoption passing confidence

Release Notes

NightlyCommit/twing-loader

v4.0.0

Compare Source


Configuration

📅 Schedule: "before 9am on monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team June 28, 2021 04:39
@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2021

⚠️ No Changeset found

Latest commit: 0e74fb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovate renovate bot force-pushed the renovate/twing-loader-4.x branch from 8c09fae to d824607 Compare June 28, 2021 18:04
@renovate renovate bot force-pushed the renovate/twing-loader-4.x branch from d824607 to 0e74fb5 Compare June 28, 2021 18:08
@calebeby
Copy link
Member

I'm gonna close this for now because it will require a lot of changes, and it is not urgent.

Twing changed to be async instead of sync, and there is a possibility that Storybook will either make that really really difficult, or impossible.

I may get to this eventually, or it might be OK for us to be staying on the old version. If we end up in a situation where we need twig language features that are only in newer versions, then we can reopen this / bump up its priority.

@calebeby calebeby closed this Jun 28, 2021
@renovate
Copy link
Contributor Author

renovate bot commented Jun 28, 2021

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 4.x releases. But if you manually upgrade to 4.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/twing-loader-4.x branch June 28, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants