-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency gulp-svgmin to v4 #1413
Conversation
|
b078109
to
c57b2b9
Compare
53e4c76
to
f5c15a8
Compare
4f192c3
to
4556d68
Compare
4556d68
to
dec9ea7
Compare
@tylersticka Do you mind reviewing my changes? gulp-svgmin updates svgo to v2. The breaking change is the way plugins are specified. If you specify a plugins array, then svgo disables all the default plugins and only uses the ones you specify. You have to call the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
svgr only supports svgo 1: https://github.com/gregberge/svgr/blob/main/packages/plugin-svgo/package.json. Closing this PR until svgr supports svgo 2 (I don't want to have multiple svgo versions and have to manage multiple svgo configs) |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
3.0.0
->4.0.1
Release Notes
ben-eb/gulp-svgmin
v4.0.1
Compare Source
v4.0.0
Compare Source
Configuration
📅 Schedule: "before 9am on monday" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.