Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency gulp-svgmin to v4 #1413

Closed
wants to merge 2 commits into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 19, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
gulp-svgmin 3.0.0 -> 4.0.1 age adoption passing confidence

Release Notes

ben-eb/gulp-svgmin

v4.0.1

Compare Source

v4.0.0

Compare Source

  • Bump svgo to v2.3.1. (thanks to @​JohnAlbin)
  • Drop node 10 support.
  • Replace eslint-config-cssnano with xo.
  • Update babel to v7 and ava to v3 (thanks to @​JohnAlbin)
  • Update dependencies.

Configuration

📅 Schedule: "before 9am on monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team July 19, 2021 08:28
@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2021

⚠️ No Changeset found

Latest commit: 8a0c79a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovate renovate bot force-pushed the renovate/gulp-svgmin-4.x branch 20 times, most recently from b078109 to c57b2b9 Compare July 26, 2021 09:19
@renovate renovate bot force-pushed the renovate/gulp-svgmin-4.x branch 8 times, most recently from 53e4c76 to f5c15a8 Compare July 29, 2021 17:21
@renovate renovate bot force-pushed the renovate/gulp-svgmin-4.x branch 5 times, most recently from 4f192c3 to 4556d68 Compare August 2, 2021 23:51
@renovate renovate bot force-pushed the renovate/gulp-svgmin-4.x branch from 4556d68 to dec9ea7 Compare August 3, 2021 19:27
@calebeby
Copy link
Member

calebeby commented Aug 4, 2021

@tylersticka Do you mind reviewing my changes? gulp-svgmin updates svgo to v2. The breaking change is the way plugins are specified. If you specify a plugins array, then svgo disables all the default plugins and only uses the ones you specify. You have to call the extendDefaultPlugins function to merge the plugin array with the default plugins. That's not possible in a yml file, so I moved the svgo config to the svg-to-twig gulp task. Can you confirm that I'm not breaking anything, and especially that the svgo config isn't used anywhere else?

@calebeby calebeby requested review from tylersticka and removed request for a team August 4, 2021 22:37
Copy link
Member

@tylersticka tylersticka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .svgo.yml file was primarily used by our Storybook icon listing. This change introduces regressions as the default SVGO settings are too aggressive.

Screen Shot 2021-08-09 at 7 38 27 AM

@calebeby
Copy link
Member

calebeby commented Aug 9, 2021

svgr only supports svgo 1: https://github.com/gregberge/svgr/blob/main/packages/plugin-svgo/package.json.

Closing this PR until svgr supports svgo 2 (I don't want to have multiple svgo versions and have to manage multiple svgo configs)

@calebeby calebeby closed this Aug 9, 2021
@renovate
Copy link
Contributor Author

renovate bot commented Aug 9, 2021

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 4.x releases. But if you manually upgrade to 4.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/gulp-svgmin-4.x branch August 9, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants