Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the format of CREATE INDEX statement #228

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Fix the format of CREATE INDEX statement #228

merged 3 commits into from
Dec 18, 2024

Conversation

apstndb
Copy link
Contributor

@apstndb apstndb commented Dec 18, 2024 •
edited
Loading

This PR fixes the format of CREATE INDEX statement to more official format.

-CREATE INDEX foo_bar ON foo (bar DESC, baz ASC)
+CREATE INDEX foo_bar ON foo(bar DESC, baz ASC)

It is requested by another user in GCPUG Slack #memefish so I want to prioritize it.

@apstndb apstndb force-pushed the fix/create-index-sql branch from cb0ff10 to 2a78c81 Compare December 18, 2024 00:44
@apstndb apstndb mentioned this pull request Dec 18, 2024
Open
makenowjust
makenowjust approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@makenowjust makenowjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@makenowjust makenowjust merged commit eccf53d into cloudspannerecosystem:main Dec 18, 2024
2 checks passed
@apstndb apstndb deleted the fix/create-index-sql branch December 20, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makenowjust makenowjust makenowjust approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apstndb @makenowjust