Player: Fix collision height check login protocol

cmangos · Jan 4, 2025 · aa6d157 · aa6d157
1 parent d0d657a
commit aa6d157
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/game/Entities/Player.cpp b/src/game/Entities/Player.cpp
@@ -21464,6 +21464,9 @@ void Player::SendInitialPacketsAfterAddToMap()
     if (IsImmobilizedState()) // TODO: Figure out if this protocol is correct
         SendMoveRoot(true);
 
+    if (m_pendingMountId)
+        SendCollisionHeightUpdate(CalculateCollisionHeight(m_pendingMountId));
+
     SendAurasForTarget(this);
 
     SendEnchantmentDurations();                             // must be after add to map

diff --git a/src/game/Entities/Unit.cpp b/src/game/Entities/Unit.cpp
@@ -10617,6 +10617,9 @@ void Unit::RemoveFromWorld()
                 transport->RemovePassenger(this);
 
         m_FollowingRefManager.clearReferences();
+
+        if (m_vehicleInfo)
+            m_vehicleInfo->Cleanup();
     }
 
     WorldObject::RemoveFromWorld();
@@ -12570,7 +12573,7 @@ void Unit::EndSpline()
 
 void Unit::SendCollisionHeightUpdate(float height)
 {
-    if (IsClientControlled())
+    if (IsClientControlled() && IsInWorld())
     {
         if (Player const* player = GetControllingPlayer())
         {