Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated packages #54

Merged
merged 9 commits into from
Oct 18, 2023
Merged

Remove deprecated packages #54

merged 9 commits into from
Oct 18, 2023

Conversation

Alkiimista
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #54 (778e357) into master (5713433) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 778e357 differs from pull request most recent head 61263c9. Consider uploading reports for the commit 61263c9 to get more accurate results

@@            Coverage Diff            @@
##            master       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           59        53    -6     
  Branches         7         4    -3     
=========================================
- Hits            59        53    -6
Files Coverage Δ
lib/MessageApiClient.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Alkiimista Alkiimista changed the title Feature/remove deprecated packages Remove deprecated packages Oct 18, 2023
@Alkiimista Alkiimista marked this pull request as ready for review October 18, 2023 14:02
SoufyanBreda2
SoufyanBreda2 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@SoufyanBreda2 SoufyanBreda2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@SoufyanBreda2 SoufyanBreda2 merged commit da9a878 into master Oct 18, 2023
2 checks passed
@Alkiimista Alkiimista deleted the feature/remove-deprecated-packages branch October 23, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoufyanBreda2 SoufyanBreda2 SoufyanBreda2 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alkiimista @SoufyanBreda2