add topn_per_group plan and executors for leaderboard task #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
approved these changes
Oct 25, 2023
| std::size_t n_; | ||
|
|
||
| protected: | ||
| auto PlanNodeToString() const -> std::string override { return "TopNPerGroupPlan PlanNodeToString Not Implemented"; }; |
There was a problem hiding this comment.
I would suggest implementing this for students, otherwise they will never implement it by themselves...
Signed-off-by: Nicola115 <[email protected]>
AveryQi115
force-pushed
the
p3_topn_per_group
branch
from
e2fc0dc to
4f31e30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT PUSH PROJECT SOLUTIONS PUBLICLY.
And especially do NOT open pull requests with project solutions!
Please be considerate of this free educational resource.