Bump the patternfly group with 2 updates #21399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
github-actions
bot
changed the title
allisonkarlitskaya
force-pushed
the
dependabot/npm_and_yarn/patternfly-65db92bc16
branch
2 times, most recently
from
66874c0 to
bacd668
Compare
|
@mvollmer This is a PF change to the TypeaheadSelect component. Is this legit or a regression? Can you please have a look? Thanks! |
|
The test was always flaky, because of asynchronicity and general messedupnes of the PF typeahed template. (I am getting more and more disillusioned with PF code quality.) |
This was referenced Dec 9, 2024
That was unfair: the messedupnes only exists with this new version of PF. All code based on the templates and on the old examples needs to be updated. |
allisonkarlitskaya
force-pushed
the
dependabot/npm_and_yarn/patternfly-65db92bc16
branch
from
aeafea9 to
c66ab56
Compare
… changes The new PF version will move the keyboard focus into the SelectList of a opened Select when the user presses ArrowUp or ArrowDown keys. Further keyboard navigation then happens by moving the focus around in that list. However, TypeaheadSelect and MultiTypeaheadSelect templated implement their own custom keyboard navigation based on the (now broken) assumption that the text input stays in focus all the time. To restore the assumption, Select has a new "typeahead" variant that switches off its new key handling, letting the Typeahead templates live in the past for a little while longer. See patternfly/patternfly-react#11249
Bumps the patternfly group with 2 updates: [@patternfly/react-core](https://github.com/patternfly/patternfly-react) and [@patternfly/react-table](https://github.com/patternfly/patternfly-react). Updates `@patternfly/react-core` from 5.4.10 to 5.4.11 - [Release notes](https://github.com/patternfly/patternfly-react/releases) - [Commits](https://github.com/patternfly/patternfly-react/compare/@patternfly/[email protected]...@patternfly/[email protected]) Updates `@patternfly/react-table` from 5.4.11 to 5.4.12 - [Release notes](https://github.com/patternfly/patternfly-react/releases) - [Commits](https://github.com/patternfly/patternfly-react/compare/@patternfly/[email protected]...@patternfly/[email protected]) --- updated-dependencies: - dependency-name: "@patternfly/react-core" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patternfly - dependency-name: "@patternfly/react-table" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patternfly ... Signed-off-by: dependabot[bot] <[email protected]>
martinpitt
force-pushed
the
dependabot/npm_and_yarn/patternfly-65db92bc16
branch
from
c66ab56 to
c1432b9
Compare
martinpitt
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the patternfly group with 2 updates: @patternfly/react-core and @patternfly/react-table.
Updates
@patternfly/react-corefrom 5.4.10 to 5.4.11Commits
2c6037echore(release): releasing packages [ci skip]623da5efeat(V5 Select/Dropdown/MenuContainer): arrow key handling to focus items (#1...af540d5chore(deps): update dependency sass to ^1.81.0 (#11258)ceb5d0echore(deps): update dependency rollup to ^4.27.3 (#11257)a7657efchore(deps): update dependency globals to ^15.12.0 (#11255)d0af1c8chore(deps): update dependency eslint-plugin-testing-library to ^6.5.0 (#11254)75638d7chore(deps): update dependency@testing-library/jest-domto ^6.6.3 (#11251)Updates
@patternfly/react-tablefrom 5.4.11 to 5.4.12Commits
2c6037echore(release): releasing packages [ci skip]623da5efeat(V5 Select/Dropdown/MenuContainer): arrow key handling to focus items (#1...af540d5chore(deps): update dependency sass to ^1.81.0 (#11258)ceb5d0echore(deps): update dependency rollup to ^4.27.3 (#11257)a7657efchore(deps): update dependency globals to ^15.12.0 (#11255)d0af1c8chore(deps): update dependency eslint-plugin-testing-library to ^6.5.0 (#11254)75638d7chore(deps): update dependency@testing-library/jest-domto ^6.6.3 (#11251)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions