login: Beibooting to all supported OSes #21501
Draft
+60
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should use our conditional `debug()` helper, not be printed unconditionally.
Previously we only allowed beibooting to the same target OS as the host. But we know which OSes Cockpit works on -- exactly the ones which we have in CI. Building that supported list isn't quite easy, though: It *roughly* corresponds to our bots/lib/testmap.py, but not quite -- e.g. "debian-stable" is "Debian 12" right now, and we don't get the official human names (such as "Red Hat Enterprise Linux" or "CentOS Stream") from the testmap either. So for the time being, keep that list static. We'll have to update it for each new OS that we support, but our integration tests will tell us. In the future we might be doing something clever, like automatically collecting `os-release` files from all our supported images in bots, and use that to auto-build `osinfo.py`. https://issues.redhat.com/browse/COCKPIT-1193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only allowed beibooting to the same target OS as the host.
But we know which OSes Cockpit works on -- exactly the ones which we
have in CI.
Building that supported list isn't quite easy, though: It roughly
corresponds to our bots/lib/testmap.py, but not quite -- e.g.
"debian-stable" is "Debian 12" right now, and we don't get the official
human names (such as "Red Hat Enterprise Linux" or "CentOS Stream") from
the testmap either. So for the time being, keep that list static. We'll
have to update it for each new OS that we support, but our integration
tests will tell us.
In the future we might be doing something clever, like automatically
collecting
os-releasefiles from all our supported images in bots, anduse that to auto-build
osinfo.py.https://issues.redhat.com/browse/COCKPIT-1193
PLATFORM_IDso that we support "RHEL 9", not "RHEL 9.6"Do we really need to show it, or perhaps just "Testux 1.2.3 is unsupported blabla"? Showing the list is kind of moot, it's not like the admin can spontaneously change the target system's OS or admin a different machine instead.