[fix] +- Change appearing for a PR (#3619)

Co-authored-by: sentry-autofix[bot] <157164994+sentry-autofix[bot]@users.noreply.github.com>
codecov · Jan 2, 2025 · ecdafdb · ecdafdb
1 parent 0e9f64a
commit ecdafdb
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/ui/TotalsNumber/TotalsNumber.test.tsx b/src/ui/TotalsNumber/TotalsNumber.test.tsx
@@ -137,6 +137,25 @@ describe('TotalsNumber', () => {
 
       const changeValue = screen.getByTestId('change-value')
       expect(changeValue).toHaveTextContent('0')
+      expect(changeValue).not.toHaveClass("before:content-['+']")
+
+      const numberValue = screen.getByTestId('number-value')
+      expect(numberValue).toHaveClass('bg-ds-coverage-covered')
+    })
+
+    it('does not render + sign for zero value', () => {
+      render(
+        <TotalsNumber
+          value={0}
+          variant="default"
+          showChange
+          data-testid="change-value"
+        />
+      )
+
+      const changeValue = screen.getByTestId('change-value')
+      expect(changeValue).toHaveTextContent('0')
+      expect(changeValue).not.toHaveClass("before:content-['+']")
 
       const numberValue = screen.getByTestId('number-value')
       expect(numberValue).toHaveClass('bg-ds-coverage-covered')

diff --git a/src/ui/TotalsNumber/TotalsNumber.tsx b/src/ui/TotalsNumber/TotalsNumber.tsx
@@ -28,7 +28,7 @@ const getNumberClasses = ({
       hasValue && parseFloat(value.toFixed(2)) < 0 && !plain,
     'bg-ds-coverage-covered':
       hasValue && parseFloat(value.toFixed(2)) >= 0 && !plain,
-    "before:content-['+']": hasValue && showChange,
+    "before:content-['+']": hasValue && showChange && value > 0,
   })
 }