-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate useSelfHostedCurrentUser to TS Query V5 #3582
base: main
Are you sure you want to change the base?
chore: Migrate useSelfHostedCurrentUser to TS Query V5 #3582
Conversation
Bundle ReportChanges will increase total bundle size by 5.32kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 5.32kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3582 +/- ##
==========================================
- Coverage 99.00% 98.99% -0.01%
==========================================
Files 810 810
Lines 14554 14556 +2
Branches 4142 4143 +1
==========================================
+ Hits 14409 14410 +1
- Misses 138 139 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3582 +/- ##
==========================================
- Coverage 99.00% 98.99% -0.01%
==========================================
Files 810 810
Lines 14554 14556 +2
Branches 4142 4143 +1
==========================================
+ Hits 14409 14410 +1
- Misses 138 139 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3582 +/- ##
==========================================
- Coverage 99.00% 98.99% -0.01%
==========================================
Files 810 810
Lines 14554 14556 +2
Branches 4142 4143 +1
==========================================
+ Hits 14409 14410 +1
- Misses 138 139 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3582 +/- ##
==========================================
- Coverage 99.00% 98.99% -0.01%
==========================================
Files 810 810
Lines 14554 14556 +2
Branches 4142 4150 +8
==========================================
+ Hits 14409 14410 +1
- Misses 138 139 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
const { data } = useSelfHostedCurrentUser() | ||
const { provider } = useParams<URLParams>() | ||
const { data } = useSuspenseQueryV5( | ||
SelfHostedCurrentUserQueryOpts({ provider }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same Q re: provider is case-sensitive here? - #3580 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answer in the previous thread
1cca9c1
to
6d8af86
Compare
Description
This PR migrates the
useSelfHostedCurrentUser
to the TS Query V5 queryOptions API versionSelfHostedCurrentUserQueryOpts
Ticket: codecov/engineering-team#2961
Notable Changes
useSelfHostedCurrentUser
toSelfHostedCurrentUserQueryOpts
useSelfActivationMutation
to TS Query V5AdminLink
,Profile
,ActivationBanner
,useSelfActivationMutation
,AdminSettings
, ActivationRequiredSelfHosted` x 2