Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fetch isCached Field with CommitPageDataQueryOpts #3621

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates the query for CommitPageDataQueryOpts to grab the isCached field which will be used in a later PR to create a banner informing the user that there is data in the commit that has been cached from a previous commit.

Ticket: codecov/engineering-team#3152

Notable Changes

  • Update CommitPageDataQueryOpts query and validation schema
  • Update MSW mock responses

@codecov-staging
Copy link

codecov-staging bot commented Jan 2, 2025

Bundle Report

Changes will increase total bundle size by 638 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 6.06MB 319 bytes (0.01%) ⬆️
gazebo-staging-system 6.0MB 319 bytes (0.01%) ⬆️

Copy link

codecov bot commented Jan 2, 2025

Bundle Report

Changes will increase total bundle size by 638 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.0MB 319 bytes (0.01%) ⬆️
gazebo-production-system-esm 6.06MB 319 bytes (0.01%) ⬆️

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (0e9f64a) to head (6a55724).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3621   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         810      810           
  Lines       14556    14558    +2     
  Branches     4140     4147    +7     
=======================================
+ Hits        14409    14411    +2     
  Misses        140      140           
  Partials        7        7           
Files with missing lines Coverage Δ
...mmitDetailPage/queries/CommitPageDataQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <100.00%> (+<0.01%) ⬆️
Services 99.36% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9f64a...6a55724. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (0e9f64a) to head (6a55724).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3621   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         810      810           
  Lines       14556    14558    +2     
  Branches     4147     4147           
=======================================
+ Hits        14409    14411    +2     
  Misses        140      140           
  Partials        7        7           
Files with missing lines Coverage Δ
...mmitDetailPage/queries/CommitPageDataQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <100.00%> (+<0.01%) ⬆️
Services 99.36% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9f64a...6a55724. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3621   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         810      810           
  Lines       14556    14558    +2     
  Branches     4147     4140    -7     
=======================================
+ Hits        14409    14411    +2     
  Misses        140      140           
  Partials        7        7           
Files with missing lines Coverage Δ
...mmitDetailPage/queries/CommitPageDataQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <100.00%> (+<0.01%) ⬆️
Services 99.36% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9f64a...6a55724. Read the comment docs.

@aj-codecov
Copy link
Contributor

@codecov-ai-reviewer review

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
6a55724 Thu, 02 Jan 2025 18:21:08 GMT Cloud Enterprise

Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants