-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fetch isCached Field with CommitPageDataQueryOpts #3621
base: main
Are you sure you want to change the base?
feat: Fetch isCached Field with CommitPageDataQueryOpts #3621
Conversation
Bundle ReportChanges will increase total bundle size by 638 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 638 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3621 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 810 810
Lines 14556 14558 +2
Branches 4140 4147 +7
=======================================
+ Hits 14409 14411 +2
Misses 140 140
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3621 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 810 810
Lines 14556 14558 +2
Branches 4147 4147
=======================================
+ Hits 14409 14411 +2
Misses 140 140
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3621 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 810 810
Lines 14556 14558 +2
Branches 4147 4140 -7
=======================================
+ Hits 14409 14411 +2
Misses 140 140
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
@codecov-ai-reviewer review |
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Description
This PR updates the query for
CommitPageDataQueryOpts
to grab theisCached
field which will be used in a later PR to create a banner informing the user that there is data in the commit that has been cached from a previous commit.Ticket: codecov/engineering-team#3152
Notable Changes
CommitPageDataQueryOpts
query and validation schema