Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: https remotes in coverage feature #57

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix: https remotes in coverage feature #57

merged 2 commits into from
Dec 9, 2024

Conversation

spalmurray-codecov
Copy link
Collaborator

Fixes a bug where https remotes were not getting read in properly. Now we support both https and ssh auth.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review December 9, 2024 22:49
ajay-sentry
ajay-sentry approved these changes Dec 9, 2024
View reviewed changes
Copy link

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Small cleanliness thing mentioned on slack

@spalmurray-codecov spalmurray-codecov merged commit 13cb8fd into main Dec 9, 2024
1 check passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/fix-https-remote branch December 9, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-sentry ajay-sentry ajay-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spalmurray-codecov @ajay-sentry