Extend helper assert with generic comparison and print message on success #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent workshop participants were repeatedly confused by the lack of output in the exercises and kept asking if no output means success. Make the
SYCLACADEMY_ASSERT
macro print[SUCCESS] Test passed
on success and[FAILURE] ...
with the same message as before on failure.There was a lot of code like:
It would be silly for the program to print 1024 lines of the same success message, so replace this kind of comparison with a new
SYCL_ACADEMY_ASSERT_EQUAL
macro which implements a generic comparison function supporting element-wise comparison of arrays/vectors and only calls theSYCLACADEMY_ASSERT
once, and therefore prints SUCCESS/FAILURE once.