Merge pull request #70 from codex-team/fix_header_&_home_i18n

fix: header & homepage i18n
codex-team · Oct 26, 2023 · fa34b55 · fa34b55
2 parents 5b515de + bb13430
commit fa34b55
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/src/application/i18n/messages/en.json b/src/application/i18n/messages/en.json
@@ -6,9 +6,14 @@
     "title": "Settings",
     "changeTheme": "Change theme"
   },
+  "header": {
+    "buttons": {
+      "home": "Home",
+      "noteSettings": "Settings"
+    }
+  },
   "home": {
-    "title": "Home",
-    "settings": "Settings"
+    "title": "Recent Notes"
   },
   "errors": {
     "404": "Page not found",

diff --git a/src/application/services/useLayout.ts b/src/application/services/useLayout.ts
@@ -1,4 +1,4 @@
-import { shallowRef, type ShallowRef, type Component, onBeforeMount, watch } from 'vue';
+import { shallowRef, type ShallowRef, type Component, watch } from 'vue';
 import { useRoute } from 'vue-router';
 import Default from '@/presentation/layouts/Default.vue';
 import Fullpage from '@/presentation/layouts/Fullpage.vue';

diff --git a/src/presentation/components/header/Header.vue b/src/presentation/components/header/Header.vue
@@ -40,7 +40,7 @@ const { user } = useAppState();
 const tabs = computed<Tab[]>(() => {
   const availableTabs = [
     {
-      title: t('home.title'),
+      title: t('header.buttons.home'),
       path: '/',
       icon: IconPicture,
       isActive: currentRoute.value.name === 'home',
@@ -53,7 +53,7 @@ const tabs = computed<Tab[]>(() => {
    */
   if ( currentRoute.value.name === 'note') {
     availableTabs.push({
-      title: t('home.settings'),
+      title: t('header.buttons.noteSettings'),
       path: currentRoute.value.path + '/settings',
       icon: IconMenu,
       isActive: false,
@@ -66,7 +66,7 @@ const tabs = computed<Tab[]>(() => {
    */
   if ( currentRoute.value.name === 'settings') {
     availableTabs.push({
-      title: t('home.settings'),
+      title: t('header.buttons.noteSettings'),
       path: currentRoute.value.path,
       icon: IconMenu,
       isActive: true,

diff --git a/src/presentation/pages/Home.vue b/src/presentation/pages/Home.vue
@@ -1,6 +1,6 @@
 <template>
   <div>
-    <h1>Recent Notes</h1>
+    <h1>{{ $t('home.title') }}</h1>
     <p>This page will contain your Notes you recently worked with </p>
   </div>
 </template>