handshake refactor #1469
Draft
handshake refactor #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
cb-jake
reviewed
Jan 6, 2025
Comment on lines
+61
to
+67
| const signerType = await this.requestSignerSelection(args); | ||
| const signer = this.initSigner(signerType); | ||
| await signer.lightHandshake?.(args); | ||
| this.signer = signer; | ||
| storeSignerType(signerType); | ||
|
|
||
| return signer.request(args); |
There was a problem hiding this comment.
It's strange to default any called RPC into this flow. This assumes intent that all apps are using smart wallet when thats not the case today. For example, calling eth_accounts should throw a 4100 err code (not authorized) where this now assumes intent to initialize a smart wallet signer. When walletlink is removed, thats becomes a "safer" assumption but ideally the SDK should remain somewhat agnostic to the connection type ensuring max compatibility in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
eth_requestAccountswallet_sendCalls,wallet_sign, andwallet_getCallsStatusrequests are allowed.eth_requestAccountsbefore or after this light handshake and the rest of the flow will continue to work like usual.How did you test your changes?