Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update headerforwarder (mesh-sdk-go) to v0.8.7 #137

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

potterbm-cb
Copy link
Contributor

Motivation

A newer release of mesh-sdk-go provides more features, in particular some improvements to outgoing headers.

Solution

In order to keep header management simpler, this PR removes some of the context management to make go-ethereum add headers to requests. Instead, the HeaderForwarder http.RoundTripper will do the work of managing outgoing headers to native nodes as well as incoming headers.

@cb-heimdall
Copy link

cb-heimdall commented Nov 13, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Contributor

@marklandgrebe-cb marklandgrebe-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@potterbm-cb potterbm-cb merged commit bd67e53 into master Nov 14, 2024
10 checks passed
@potterbm-cb potterbm-cb deleted the bryan/chore-update-headerforwarder branch November 14, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants