Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Fund Card component #1718

Open
wants to merge 75 commits into
base: main
Choose a base branch
from
Open

Implement Fund Card component #1718

wants to merge 75 commits into from
+3,175 −60

Conversation

rustam-cb
Copy link
Contributor

@rustam-cb rustam-cb commented Dec 11, 2024 •
edited
Loading

What changed? Why?
Implemented a new component FundCard
P/PS: https://docs.google.com/document/d/1y57fxsga2ZLF8-ieH2OY7jvqx5468txQuek1WTYPBxE/edit?tab=t.0

Usage:

FundCard assetSymbol="ETH" />

Component is customizable and there are few components that can be passed into it.

  AmountInputComponent 
  HeaderComponent
  AmountInputTypeSwithComponent
  PaymentMethodSelectorDropdownComponent
  SubmitButtonComponent
Fiat input Crypto input
Screenshot 2024-12-17 at 9 38 52 PM Screenshot 2024-12-17 at 9 39 06 PM
No input (default) payment method dropdown
Screenshot 2024-12-17 at 9 38 41 PM Screenshot 2024-12-17 at 9 39 20 PM

Notes to reviewers
Overall component structure:

  • FundCard
    • HeaderComponent
    • AmountInputComponent
    • PaymentMethodDropdownComponent
    • SubmitButtonComponent

How has it been tested?

  • Unit tests
  • Manual testing

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 11:09pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 11:09pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 11:09pm

@rustam-cb rustam-cb requested a review from alessey January 8, 2025 00:48
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 8, 2025
View reviewed changes
src/fund/components/FundCard.test.tsx Dismissed Show dismissed Hide dismissed
@rustam-cb rustam-cb requested a review from alessey January 8, 2025 18:35
@mindapivessa
Copy link
Contributor

Coinbase C should be Coinbase Blue.

@rustam-cb rustam-cb requested a review from abcrane123 January 8, 2025 23:16
abcrane123
abcrane123 previously approved these changes Jan 9, 2025
View reviewed changes
@abcrane123 abcrane123 self-requested a review January 9, 2025 17:51
@abcrane123 abcrane123 dismissed their stale review January 9, 2025 17:57

found a few small issues when testing in playground

@abcrane123
Copy link
Contributor

i think the buy button is disabled here because i haven't connected wallet. you can probably do the same thing I did in the Buy component (replace buy button with connect wallet button if not connected)

Screenshot 2025-01-09 at 9 55 46 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschlabach dschlabach Awaiting requested review from dschlabach

@cpcramer cpcramer Awaiting requested review from cpcramer

@alessey alessey Awaiting requested review from alessey

@abcrane123 abcrane123 Awaiting requested review from abcrane123

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation pkg: fund pkg: styles pkg: swap root
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rustam-cb @cpcramer @alessey @mindapivessa @abcrane123 @dschlabach